RE2 Review: ✅ Approve

Clean implementation — migration is safe (NOT NULL DEFAULT won't break existing rows), API validation is correct with shared CONTENT_TYPES constant, admin-only gate on updates is properly enforced with 403, and badge rendering follows existing patterns.

Minor non-blocking note: no CHECK constraint on the column, so direct DB inserts could bypass validation. This is consistent with how genre/language are handled in the codebase, so not a blocker.

CI: lint-and-typecheck green, e2e pending at time of review.

Verdict: REQUEST CHANGES

Summary

The PR implements the main API/UI wiring for content_type, but the allowed value contract is not fully enforced. Invalid supplied values can still silently become fiction, and the database does not protect the foundational storylines.content_type column from out-of-band invalid writes.

Findings

• [medium] Invalid non-string/falsy contentType values are accepted as the default fiction instead of being rejected with 400.

  • File: src/app/api/index/storyline/route.ts:49
  • Suggestion: Validate based on property presence, not truthiness. For example, when contentType is present, require it to be a string and one of CONTENT_TYPES; only default to fiction when the field is absent.

• [medium] The migration adds content_type without a database constraint, so the stated allowed values are not enforced at the source of truth.

  • File: supabase/migrations/00039_add_content_type.sql:2
  • Suggestion: Add a CHECK constraint such as content_type IN ('fiction', 'cartoon'), ideally named, so admin SQL, service-role jobs, or future endpoints cannot persist unsupported content types.

Decision

Requesting changes because #1212 defines content_type as the foundation for downstream cartoon work. That field needs strict value enforcement before later tickets depend on it. Note: lint/typecheck is green, but e2e was still pending at review time.

Verdict: APPROVE

Summary

The requested fixes are in place. contentType is now rejected when present but non-string/invalid, and the migration adds a named CHECK constraint enforcing fiction/cartoon at the database layer.

Findings

• None blocking.

Decision

Approved. The prior RE1 findings are resolved. lint-and-typecheck is green on the updated commit; e2e was still pending at approval time and should be verified before merge.

RE2 Re-review: ✅ Approve

Both fixes correctly address RE1's findings:

1. Strict validation — uses "contentType" in body for presence check, rejects non-string/invalid with 400, only defaults to fiction when field is absent.
2. CHECK constraint added to migration — DB-level enforcement now in place.

lint-and-typecheck green. e2e pending. No further concerns from RE2.